I think we need to create separate stubs for separate laravel versions? It seems like laravel 7 introduced the ability for attributes to be nullable if I'm reading the docs right. Laravel 6 does not allow that.

We should probably take a similar approach as the symfony plugin: https://github.com/psalm/psalm-plugin-symfony/tree/master/src/Stubs

A test would be nice as that would verify the issue I'm bringing up, I believe

It seems like laravel 7 introduced the ability for attributes to be nullable if I'm reading the docs right. Laravel 6 does not allow that.

It's a bit inconsistent:

• Laravel 6 did always require $attributes to be passed.
• Laravel 7 allowed Builder::firstOrNew() to be called without attributes (but not Builder::firstOrCreate()).
• Laravel 8 allowed Builder::firstOrCreate(), HasOneOrMany::firstOrNew() and HasOneOrMany::firstOrCreate() to be called without attributes.
• Laravel 9 will allow BelongsToMany::firstOrNew() and BelongsToMany::firstOrCreate() to be called without attributes (if [9.x] Support calling BelongsToMany::firstOrNew/Create without parameters laravel/framework#37791 gets merged).

A test would be nice as that would verify the issue I'm bringing up, I believe

I guess the test would need to have different expectations depending on the Laravel version?

edit: I'm not familiar with behat, but we probably need a condition that restricts a test to a Laravel version, like Given I have Laravel 8 installed.

We should probably take a similar approach as the symfony plugin: https://github.com/psalm/psalm-plugin-symfony/tree/master/src/Stubs

Implemented in 7f9994d.

@mr-feek Any tips how to add test scenarios that only run with a specific Laravel major version, and that are skipped otherwise? I only found some unconditional @skip annotations.

I think it might need a custom codeception module helper...

@weirdan implemented this for determining the version of psalm at runtime during tests.. could do something similar https://github.com/psalm/codeception-psalm-module/blob/master/src/Module.php#L201-L235

Custom step is not required. You can check the version of any package, see release notes for v0.9.0

One step ahead of us :) thanks @weirdan !

Cherry-picked 1191d0f from #181 to see if the tests pass.

thanks!